Level Up Coding

Coding tutorials and news. The developer homepage gitconnected.com && skilled.dev && levelup.dev

Follow publication

Code Smell 293 — isTesting

Maximiliano Contieri
Level Up Coding
Published in
3 min read5 days ago

TL;DR: Avoid adding isTesting or similar flags.

Problems 😔

Solutions 😃

  1. Remove behavior Ifs
  2. Use dependency injection
  3. Model external services (Don’t mock them)
  4. Separate configurations
  5. Isolate test logic
  6. Maintain clean behavior boundaries

Refactorings ⚙️

Context 💬

When you add flags like isTesting, you mix testing and production code.

This creates hidden paths that are only active in tests.

Also, you don’t cover real production code.

You risk shipping testing behavior to production, leading to bugs and unpredictable behavior.

Sample Code 📖

Wrong ❌

struct PaymentService {
is_testing: bool,
}

impl PaymentService {
fn process_payment(&self, amount: f64) {
if self.is_testing {
println!("Testing mode: Skipping real payment");
return;
}
println!("Processing payment of ${}", amount);
}
}

Right 👉

trait PaymentProcessor {
fn process(&self, amount: f64);
}

struct RealPaymentProcessor;
impl PaymentProcessor for RealPaymentProcessor {
fn process(&self, amount: f64) {
println!("Processing payment of ${}", amount);
}
}

struct TestingPaymentProcessor;
impl PaymentProcessor for TestingPaymentProcessor {
// Notice this is not a mock
fn process(&self, _: f64) {
println!("No payment: Skipping real transaction");
}
}

struct PaymentService<T: PaymentProcessor> {
processor: T,
}

impl<T: PaymentProcessor> PaymentService<T> {
fn process_payment(&self, amount: f64) {
self.processor.process(amount);
}
}

Detection 🔍

[X] Semi-Automatic

You can detect this smell by looking for conditional flags like isTesting, environment == ‘test’, DEBUG_MODE, and idioms like these.

These indicate that testing behavior is leaking into the production code.

Tags 🏷️

  • Testing

Level 🔋

[X] Intermediate

Why the Bijection Is Important 🗺️

You need a clear separation between test and production code.

When you mix them, you break the one-to-one Bijection between real-world behavior and the program.

Since environments are real-world entities you need to explicitly model them in the MAPPER.

AI Generation 🤖

AI-generated code often introduces this smell when you use quick hacks for testing.

Some tools suggest flags like isTesting because they prioritize ease over proper design.

AI Detection 🥃

AI tools can catch this smell if you configure them to flag conditional logic based on testing states.

Try Them! 🛠

Remember: AI Assistants make lots of mistakes

Suggested Prompt: Remove IsTesting method and replace it by modeling the environments

Without Proper Instructions

With Specific Instructions

Conclusion 🏁

Avoid using isTesting flags.

Use dependency injection and model the environments to keep test and production logic separate.

Relations 👩‍❤️‍💋‍👨

Disclaimer 📘

Code Smells are my opinion.

Credits 🙏

Photo by Christian Gertenbach on Unsplash

When you add testing flags, you undermine confidence in production.

Ward Cunningham

Sign up to discover human stories that deepen your understanding of the world.

Free

Distraction-free reading. No ads.

Organize your knowledge with lists and highlights.

Tell your story. Find your audience.

Membership

Read member-only stories

Support writers you read most

Earn money for your writing

Listen to audio narrations

Read offline with the Medium app

Written by Maximiliano Contieri

I’m a senior software engineer specialized in declarative designs. S.O.L.I.D. and agile methodologies fan. Maximilianocontieri.com

No responses yet

Write a response